Comments on: When does refactoring become something more? http://www.magpiebrain.com/blog/2004/09/09/when-does-refactoring-become-something-more/ Sam Newman's blog Fri, 08 Aug 2008 19:08:39 +0000 http://wordpress.org/?v=2.5.1 By: Abdel A Saleh http://www.magpiebrain.com/blog/2004/09/09/when-does-refactoring-become-something-more/#comment-515 Abdel A Saleh Wed, 15 Sep 2004 15:56:56 +0000 http://www.magpiebrain.com/2004/09/09/when-does-refactoring-become-something-more/#comment-515 Hi, I have to agree with Franz. In many instances where there is no tool to aid in automating a refactoring, the task (of refactoring) does take a fair bit of time, ie more than 10 minutes. But it is still a refactoring.. Hi,

I have to agree with Franz. In many instances where there is no tool to aid in automating a refactoring, the task (of refactoring) does take a fair bit of time, IE more than 10 minutes. But it is still a refactoring..

]]> By: Sam Newman http://www.magpiebrain.com/blog/2004/09/09/when-does-refactoring-become-something-more/#comment-514 Sam Newman Sun, 12 Sep 2004 11:48:27 +0000 http://www.magpiebrain.com/2004/09/09/when-does-refactoring-become-something-more/#comment-514 Perhaps what I should of said is not "is something that takes more than X a refactoring" but more "is a refactoring that takes more than X something we should do"? Perhaps what I should of said is not “is something that takes more than X a refactoring” but more “is a refactoring that takes more than X something we should do”?

]]> By: franz http://www.magpiebrain.com/blog/2004/09/09/when-does-refactoring-become-something-more/#comment-513 franz Sat, 11 Sep 2004 17:57:39 +0000 http://www.magpiebrain.com/2004/09/09/when-does-refactoring-become-something-more/#comment-513 every task that keeps the algorithm the same and just change the overall structure. i.e. class, method, parameter, field, variable etc... IS A REFACTORING. The duration of the refactoring mainly rely to the automation of it. Find and factorize duplicate code is a next refactoring task to be automated (Intellij already contains plugin in order to help in this task). That it, that's all. Don't try to complexify the refactoring meaning with duration please!!! every task that keeps the algorithm the same and just change the overall structure. i.e. class, method, parameter, field, variable etc… IS A REFACTORING.
The duration of the refactoring mainly rely to the automation of it.
Find and factorize duplicate code is a next refactoring task to be automated (Intellij already contains plugin in order to help in this task).
That it, that’s all. Don’t try to complexify the refactoring meaning with duration please!!!

]]> By: Sam Newman http://www.magpiebrain.com/blog/2004/09/09/when-does-refactoring-become-something-more/#comment-512 Sam Newman Thu, 09 Sep 2004 20:59:44 +0000 http://www.magpiebrain.com/2004/09/09/when-does-refactoring-become-something-more/#comment-512 We left it in as it did improve the code we wrote. We actually took another look at the original problem after a break and managed to fix it, so replacing all duplications. There is certainly a tradeoff between being consistently wrong and inconsistently right, and doing the best thing at the time - coding in the right way for the task at hand, where applying the 'correct' code across the codebase would involve significant effort (beyond the scope of what could be thought of as refactoring). We left it in as it did improve the code we wrote. We actually took another look at the original problem after a break and managed to fix it, so replacing all duplications.

There is certainly a tradeoff between being consistently wrong and inconsistently right, and doing the best thing at the time – coding in the right way for the task at hand, where applying the ‘correct’ code across the codebase would involve significant effort (beyond the scope of what could be thought of as refactoring).

]]> By: ade http://www.magpiebrain.com/blog/2004/09/09/when-does-refactoring-become-something-more/#comment-511 ade Thu, 09 Sep 2004 16:36:38 +0000 http://www.magpiebrain.com/2004/09/09/when-does-refactoring-become-something-more/#comment-511 Did you back out your changes or did you leave the codebase with some code using the visitor and some code doing it the old way? I think we need a word for the kind of variegated code that results when people use the time a refactoring will take as a reason to only partially apply a change. Maybe it's better to accept the duplication rather than introduce variegation--code with many different ways of doing the same thing. Did you back out your changes or did you leave the codebase with some code using the visitor and some code doing it the old way?
I think we need a word for the kind of variegated code that results when people use the time a refactoring will take as a reason to only partially apply a change. Maybe it’s better to accept the duplication rather than introduce variegation—code with many different ways of doing the same thing.

]]>